compare string contents but string pointer addresses.

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS

Apache License 2.0

117 stars 90 forks source link

compare string contents but string pointer addresses. #481

Closed fujitatomoya closed 8 months ago

fujitatomoya commented 8 months ago

address https://github.com/ros2/rmw_fastrtps/issues/742

clalancette commented 8 months ago

FYI, this is a better version of #320 , which tried to fix the same thing for the same reason but just got held up. I'm going to close that one and review this one.

fujitatomoya commented 8 months ago

CI:

Linux
Linux-aarch64
Windows

eboasson commented 8 months ago

Sorry I'm so behind on things ... I am trying to catch up, please don't think I am don't care anymore!

I would've approved this one ☺️

fujitatomoya commented 8 months ago

@eboasson thanks for the comment. no worries, same here 😅