ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
107 stars 89 forks source link

Make rmw_service_server_is_available return RMW_RET_INVALID_ARGUMENT #496

Closed christophebedard closed 2 weeks ago

christophebedard commented 4 weeks ago

https://github.com/ros2/rmw/pull/277 changed the rmw_service_server_is_available() API documentation to indicate that it returns RMW_RET_INVALID_ARGUMENT if node, client, or is_available are NULL. However, this wasn't the case in practice in the implementations of rmw_service_server_is_available() or in the relevant test.

Change the implementation here to return RMW_RET_INVALID_ARGUMENT.

Requires https://github.com/ros2/rmw_implementation/pull/231

christophebedard commented 4 weeks ago

CI is over in https://github.com/ros2/rmw_implementation/pull/231#issuecomment-2147880818