search

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
117 stars 90 forks source link

Make rmw_destroy_wait_set return RMW_RET_INVALID_ARGUMENT #498

Closed christophebedard closed 5 months ago

christophebedard commented 5 months ago

https://github.com/ros2/rmw/pull/275 changed the rmw_destroy_wait_set() API documentation to indicate that it returns RMW_RET_INVALID_ARGUMENT if wait_set is NULL. However, this wasn't the case in practice in the implementations of rmw_destroy_wait_set() or in the relevant test.

Change the implementation here to return RMW_RET_INVALID_ARGUMENT.

Requires https://github.com/ros2/rmw_implementation/pull/234

christophebedard commented 5 months ago

CI is over in https://github.com/ros2/rmw_implementation/pull/234#issuecomment-2150237344