ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
117 stars 90 forks source link

use RMW_GID_STORAGE_SIZE to client_service_id_t. #515

Closed fujitatomoya closed 1 month ago

fujitatomoya commented 1 month ago

minor fix to remove redundant check and lint, aligns with https://github.com/ros2/rmw/pull/345

fujitatomoya commented 1 month ago

@clalancette @eboasson could you take a look?

fujitatomoya commented 1 month ago

Pulls: ros2/rmw_cyclonedds#515 Gist: https://gist.githubusercontent.com/fujitatomoya/159fb39f654e136e969ca6830c5c3534/raw/8d12400542ede7611dcdb6b3391fe546e94c2271/ros2.repos BUILD args: --packages-above-and-dependencies rmw_cyclonedds_cpp TEST args: --packages-above rmw_cyclonedds_cpp ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14676

fujitatomoya commented 1 month ago

https://ci.ros2.org/job/ci_linux-rhel/1478/ is related, that is ros2cli missing the result...

since i do not have write permission here, i like to ask @clalancette @eboasson to merge this.