search

ros2 / rmw_dds_common

Apache License 2.0
11 stars 20 forks source link

Add fault injection macro unit tests #27

Closed brawner closed 4 years ago

brawner commented 4 years ago

Adding fault injection unit tests to rmw_dds_common. This should get coverage to about 99%. I'll post CI results soon.

Signed-off-by: Stephen Brawner brawner@gmail.com

brawner commented 4 years ago

Builds and tests of the following packages rcutils, rcl_logging_spdlog, rosidl_typesupport_c, rosidl_typesupport_cpp, rcl, rcl_action, rcl_lifecycle, rosidl_runtime_c, rmw_dds_common, rmw

brawner commented 4 years ago

Testing this PR branch against current ros 2 branches. Testing --packages-select rmw_dds_common

brawner commented 4 years ago
brawner commented 4 years ago

Trying again after merging https://github.com/ros2/rcutils/pull/283

brawner commented 4 years ago

rpr build fails because it requires a new release to rcutils for the fault injection macros, but the CI builds all pass so this should be good.

dirk-thomas commented 4 years ago

rpr build fails because it requires a new release to rcutils for the fault injection macros, but the CI builds all pass so this should be good.

Why not first release rcutils and once retriggered CI passes merge?

brawner commented 4 years ago

That's reasonable. It will be my first release, so I was just unsure about the whole process. I'll work to figure it out.