search

ros2 / rmw_dds_common

Apache License 2.0
11 stars 20 forks source link

Add function for checking QoS profile compatibility #45

Closed jacobperron closed 3 years ago

jacobperron commented 3 years ago

Given QoS profiles for a publisher and a subscription, this function will return true if the profiles are compatible. Compatible profiles implies that the subscription and publisher will be able to communicate.

Connected to https://github.com/ros2/rmw/pull/299

jacobperron commented 3 years ago

This conflicts with https://github.com/ros2/rmw_dds_common/pull/43, so I'll likely have to rebase once that lands.

jacobperron commented 3 years ago

Compatibility checks are based on the tables found here: https://index.ros.org/doc/ros2/Concepts/About-Quality-of-Service-Settings/#qos-compatibilities

jacobperron commented 3 years ago

@ivanpauno Thanks for the review. I think I've address all of your comments.

jacobperron commented 3 years ago

CI: https://github.com/ros2/rmw/pull/299#issue-571521564

jacobperron commented 3 years ago

@ros-pull-request-builder retest this please

jacobperron commented 3 years ago

@ros-pull-request-builder retest this please