search

ros2 / rmw_dds_common

Apache License 2.0
11 stars 20 forks source link

Add a common function for security files. #51

Closed clalancette closed 3 years ago

clalancette commented 3 years ago

All three of the in-tree DDS RMW implementation hard-code a list of files in the security enclave. Instead of doing this in three separate places, add in a common function that finds the set of files in the security enclave that are needed for DDS security.

get_security_files() currently returns them in an unordered_map. The main reason to use a map over a structure is ABI concerns; it should be easy to add another field to the unordered_map, whereas adding one to a structure would be harder. (I intend to add something to the map in the near future). It's also not performance sensitive, so the extra string allocations shouldn't hurt performance.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

clalancette commented 3 years ago

Here's full CI of this PR and the ones in the individual RMWs:

clalancette commented 3 years ago

Windows was pretty cranky, but I think I got it sorted out now. Here's another CI run:

clalancette commented 3 years ago

There have been no substantial changes to this PR since the approval (just minor changes for Windows compatibility), so I'm going to go ahead and merge this one. Thanks!