search

ros2 / rmw_dds_common

Apache License 2.0
11 stars 20 forks source link

Use rosidl_get_typesupport_target and target_link_libraries #57

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

This package is currently hard-coding the include directories for the generator packages it depends on. This makes it use rosidl_get_typesupport_target() insteadl. I also made it use target_link_libraries instead of ament_target_dependencies.

I think this depends on ros2/rosidl_typesupport#123, but I don't remember why (Edit: I think it needs that cleanup PR to get the dependency on rosidl_generator_c transitively from rosidl_generator_cpp instead of hard coding both)

sloretz commented 2 years ago

@hidmic I've added you as a reviewer, but this one seems to depend on ros2/rosidl_typesupport#123 which depends on ros2/rosidl#662, so I've left it as a draft for now.

sloretz commented 2 years ago

CI (build: --packages-above-and-dependencies rmw_dds_common test: --packages-select rmw_dds_common)