search

ros2 / rmw_dds_common

Apache License 2.0
11 stars 20 forks source link

Add pkcs11 support to get_security_files #66

Closed MiguelCompany closed 6 months ago

MiguelCompany commented 1 year ago

This implements ros2/design#332

ruffsl commented 1 year ago

Ping @clalancette or @mikaelarguedas ? Could you review?

ros-discourse commented 1 year ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-02-16/29927/1

SubaruArai commented 1 year ago

@MiguelCompany any update on this pr?

Or should we wait REP-2015 to be approved first?

MiguelCompany commented 1 year ago

@SubaruArai I don't know what the process is. I guess we should wait for REP-2015, but I am just an external contributor, and I suppose that someone in the ROS 2 team should answer that.

Maybe @clalancette or @gbiggs can clarify?

MiguelCompany commented 6 months ago

@ahcorde I just rebased this. Will try to add tests in the test_security.cpp file

MiguelCompany commented 6 months ago

@ahcorde I updated the tests in test_security.cpp

clalancette commented 6 months ago

Here is CI for this:

clalancette commented 6 months ago

A couple more pieces of CI, then I think this is good to go:

clalancette commented 6 months ago

All of the warnings here were also in the nightlies, so going ahead and merging this one in.