search

ros2 / rmw_dds_common

Apache License 2.0
11 stars 20 forks source link

Just remove rcpputils::fs dependency #72

Closed yoneken closed 1 year ago

yoneken commented 1 year ago

Because the package will be no longer available. https://github.com/ros2/rcpputils/issues/164

yoneken commented 1 year ago

Oops.. I will fix it later.

yoneken commented 1 year ago

Ready for review.

yoneken commented 1 year ago

Thanks for your valuable comments and suggestions! rcpputils is still remained at https://github.com/ros2/rmw_dds_common/blob/rolling/rmw_dds_common/src/qos.cpp#L711 .

clalancette commented 1 year ago

CI:

clalancette commented 1 year ago

@yoneken So it looks like specifically on Windows, the security tests are failing now. Can you take a look?

yoneken commented 1 year ago

I have added some changes for windows. Could you run CI?

clalancette commented 1 year ago

Here's another try at CI: