Safely convert from uint64_t to size_t.

ros2 / rmw_dps

Implementation of the ROS Middleware (rmw) Interface using Intel's Distributed Publish & Subscribe.

Apache License 2.0

23 stars 8 forks source link

Safely convert from uint64_t to size_t. #9

Closed malsbat closed 5 years ago

malsbat commented 5 years ago

This fixes #8.

Signed-off-by: Todd Malsbary todd.malsbary@intel.com

malsbat commented 5 years ago

@alsora, I can't seem to add you as a reviewer. Please leave a comment if this fixes #8.

alsora commented 5 years ago

Thank you, this fixes #8 .

However, during my previous cross-compilation I haven't noticed that the underlying DPS library was not receiving the cross-compilation flags. As a result DPS was still built for X86_64.

If I try to build DPS on 32 bit I get several similar errors.

For this reason I think that this PR should wait for DPS to be eventually updated with https://github.com/intel/dps-for-iot/issues/96

malsbat commented 5 years ago

I started an x86 branch for DPS here: https://github.com/intel/dps-for-iot/tree/x86.

malsbat commented 5 years ago

I'm going to merge this as it addresses the immediate issue. The general cross-compilation of rmw_dps will be done in a different PR.