Add EventsExecutor API for dynamic_fastrtps

ros2 / rmw_fastrtps

Implementation of the ROS Middleware (rmw) Interface using eProsima's Fast RTPS.

Apache License 2.0

157 stars 117 forks source link

Add EventsExecutor API for dynamic_fastrtps #600

Closed j-rivero closed 2 years ago

j-rivero commented 2 years ago

Fixes https://github.com/ros2/rmw_fastrtps/issues/599

Two commits:

Copy the implementation done in #468 for dynamic version
Add some check to parameters passed to fastrtps_cpp to keep both implementations in sync

Testing:

Linux
Linux-aarch64
Windows

I think that cpplint is not related to this PR. I can open a new PR to fix it.

clalancette commented 2 years ago

I think that cpplint is not related to this PR. I can open a new PR to fix it.

Yeah, agreed. I'd say let's get that fix in (I'm happy to review it), then rebase this one and get green CI. The Rpr job is going to be broken for right now until Jacob finishes doing releases for Rolling.

j-rivero commented 2 years ago

CI:

Linux
Linux-aarch64
Windows

j-rivero commented 2 years ago

Seems fine, merging.