search

ros2 / rmw_fastrtps

Implementation of the ROS Middleware (rmw) Interface using eProsima's Fast RTPS.
Apache License 2.0
157 stars 117 forks source link

Fix repeated matched event notification #682

Closed Barry-Xu-2018 closed 1 year ago

Barry-Xu-2018 commented 1 year ago

Address #681

Barry-Xu-2018 commented 1 year ago

Although this correction is targeted towards matched events, I guess other events may also have the same issue.

fujitatomoya commented 1 year ago

@MiguelCompany we would like you to review this PR, thanks in advance.

fujitatomoya commented 1 year ago

Just quick heads-up, https://docs.ros.org/en/rolling/Releases/Release-Iron-Irwini.html#release-timeline this must be addressed in this week.

MiguelCompany commented 1 year ago

@Barry-Xu-2018 @fujitatomoya I have taken a deep look into this.

Statuses publication_matched and subscription_matched should be handled specially on the RMW. In particular, they should always be enabled on the listener mask, since we need track_unique_xxx to be called.

For other statuses, the listener is not called unless an event callback is set for that status.

I have created #683 with what I consider a better approach to fix the repeated notification.

fujitatomoya commented 1 year ago

@MiguelCompany @Barry-Xu-2018

i left a couple of comments, https://github.com/ros2/rmw_fastrtps/pull/683. I was not clear that this can address the repeated issue precisely.

Barry-Xu-2018 commented 1 year ago

@MiguelCompany thanks for your explanation. I understand. I close this PR.