search

ros2 / rmw_fastrtps

Implementation of the ROS Middleware (rmw) Interface using eProsima's Fast RTPS.
Apache License 2.0
155 stars 117 forks source link

Altering liveliness lease_duration #755

Closed CursedRock17 closed 2 months ago

CursedRock17 commented 5 months ago

This pull request is supposed to solve an issue noted in this RCUTILS pr in which a qos line undergoes an incorrect conversion. The original intent was to pass an int64_t and sacrifice some accuracy, but I don't believe it's possible due to our limited constructors for Duration_t. Instead, I converted to a nanosecond value, then operated on that value by making it 2/3s the original. Then, converting that value to a sec (double) which should fill the long double argument. We shouldn't need to operate on the sec (double), after having converted, because while our new version will have less accuracy, RCUTILS_NS_TO_S is undergoing changes to become more accurate.

sloretz commented 4 months ago

@clalancette friendly ping :waffle:

fujitatomoya commented 2 months ago

@CursedRock17 https://github.com/ros2/rmw_fastrtps/pull/755#discussion_r1670636641 makes sense to me. do we close this one out?

CursedRock17 commented 2 months ago

Apologies, I wanted to go through solutions in rcutils before I came back here to clear up this pull request. Yeah we can go ahead and close this out. Though perhaps, way in the future, we may have to revisit if the MACRO behavior ends up changing.