rmw_namespace_validation_result_string() -- not rmw_node_name_validation_result_string() -- should be called with the validation result from rmw_validate_namespace().
In practice, this meant that the reason given might have been "unknown result code for rmw node name validation" given that rmw_node_name_validation_result_string() doesn't know about all validation results from rmw_validate_namespace(). However, we don't test error messages anywhere and rarely rely on them, so it doesn't/shouldn't affect any tests or functionality.
christophebedard
commented
4 weeks ago
rmw_namespace_validation_result_string()-- notrmw_node_name_validation_result_string()-- should be called with the validation result fromrmw_validate_namespace().In practice, this meant that the reason given might have been
"unknown result code for rmw node name validation"given thatrmw_node_name_validation_result_string()doesn't know about all validation results fromrmw_validate_namespace(). However, we don't test error messages anywhere and rarely rely on them, so it doesn't/shouldn't affect any tests or functionality.Related PRs: