search

ros2 / rmw_iceoryx

rmw implementation for iceoryx
Apache License 2.0
144 stars 27 forks source link

Adding event and topic info functions to RMW #18

Closed Karsten1987 closed 4 years ago

Karsten1987 commented 4 years ago

fixes #17

Karsten1987 commented 4 years ago

Current CI is only equipped to run against eloquent debs. This PR targets ROS2 master (foxy).

jeising commented 4 years ago

Current CI is only equipped to run against eloquent debs. This PR targets ROS2 master (foxy).

We would need to have release branches in our package. So we could run the CI for our master against ros2 master and eloquent branch against ros2 eloquent.

blackliner commented 4 years ago

Current CI is only equipped to run against eloquent debs. This PR targets ROS2 master (foxy).

We would need to have release branches in our package. So we could run the CI for our master against ros2 master and eloquent branch against ros2 eloquent.

Wouldn't running rmw_iceoryx - master with ros2 - eloquent and ros2 - master ensure your rmw_iceoryx stays compatible with all supported versions? I think that would be a good thing, so you do not need to work on multiple branches?

blackliner commented 4 years ago

So, since https://github.com/ros2/rmw/commits/master/rmw/include/rmw/get_topic_endpoint_info.h was created 2 month ago, i guess this new feature only works with ros2:rmw - master?

Karsten1987 commented 4 years ago

@budrus @jeising please have a look. This is ready to be merged.

I played around a little with the GitHub actions and finally landed on a private gist repo. This shall be re-iterated once https://github.com/ros-tooling/action-ros-ci/pull/121#issuecomment-610069796 is resolved.