search

ros2 / rmw_iceoryx

rmw implementation for iceoryx
Apache License 2.0
158 stars 27 forks source link

Update rmw_iceoryx so that is working with iceoryx v0.17.0 #40

Closed elfenpiff closed 3 years ago

elfenpiff commented 3 years ago

Adjust the code so that iceoryx v0.17.0 is supported.

We should explicitly support only the last "stable" version and not the experimental v0.90 since we will most likely have some major API changes in here.

mossmaurice commented 3 years ago

@elfenpiff I tried the branch foxy + v0.17.0 under Ubuntu and the talker/listner example worked (there was only an error about some missing error handling function). Can we close this issue or did you mean MacOs and Windows support here?

Here are the steps to reproduce:

# Create ADE ros2_foxy based on public image: https://gitlab.apex.ai/apex.ai-public/ros2-ade
cd ~/ros2_foxy
cd src
git clone https://github.com/eclipse/iceoryx.git
cd iceoryx && git checkout v0.17.0
cd ~/ros2_foxy/src
git clone https://github.com/ros2/rmw_iceoryx.git
sudo apt install -y cmake libacl1-dev libncurses5-dev
colcon build --symlink-install --merge-install
source install/setup.bash
# 1st ade bash window
./install/bin/RouDi
# 2n ade bash window, with the introspection one can verify that communication goes over iceoryx
./build/iceoryx_introspection/iceoryx_introspection_client --all
# 3rd ade bash window
RMW_IMPLEMENTATION=rmw_iceoryx_cpp ros2 run demo_nodes_cpp talker
# 4th ade bash window
RMW_IMPLEMENTATION=rmw_iceoryx_cpp ros2 run demo_nodes_py listener
elfenpiff commented 3 years ago

No, then we can close this issue.