search

ros2 / rmw_iceoryx

rmw implementation for iceoryx
Apache License 2.0
144 stars 27 forks source link

Update rmw_iceoryx for galactic #54

Closed mossmaurice closed 2 years ago

mossmaurice commented 2 years ago

Done

What's working

What's not working/ known limitations

Closes #48

mossmaurice commented 2 years ago

@ZhenshengLee Could you have a look at this pull request?

christophebedard commented 2 years ago

What's not working/ known limitations

>>> [rcutils|error_handling.c:108] rcutils_set_error_state()
This error state is being overwritten:

  'Handle's typesupport identifier (rosidl_typesupport_c) is not supported by this library, at /home/simon.hoinkis/ros2_galactic_ade/src/ros2/rosidl_typesupport/rosidl_typesupport_c/src/type_support_dispatch.hpp:113'

with this new error message:

  'Handle's typesupport identifier (rosidl_typesupport_cpp) is not supported by this library, at /home/simon.hoinkis/ros2_galactic_ade/src/ros2/rosidl_typesupport/rosidl_typesupport_cpp/src/type_support_dispatch.hpp:111'

rcutils_reset_error() should be called after error handling to avoid this.

I just recently found the "solution" for this case of an error message being overwritten, so I thought I'd mention it. Currently, if get_message_typesupport_handle() returns a nullptr, it sets an error message, so you're expected to call rcutils_reset_error(). Example: https://github.com/ros2/rmw_connextdds/pull/22/files#diff-8310735a1b9a2eb25a4d85563c1a1862ca08f0243488ac9867c76a7ae7d9ed01

It looks like this behaviour may change at some point though: https://github.com/ros2/rosidl_typesupport/pull/102

mossmaurice commented 2 years ago

@jeising Would you mind doing a review of the changes? Thanks in advance!

mossmaurice commented 2 years ago

@Karsten1987 Could you please set the default branch for this repository to the branch galactic? Cheers and have a nice weekend!