ros2 / rmw_iceoryx

rmw implementation for iceoryx
Apache License 2.0
144 stars 27 forks source link

Fix Python support by using C type support for message name lookup #70

Closed mossmaurice closed 2 years ago

mossmaurice commented 2 years ago

This PR fixes a bug preventing Python support (#57) by allowing the usage of the C type support.

I confirmed the bugfix by running the following four commands in four separate terminals:

iox-roudi -l verbose
RMW_IMPLEMENTATION=rmw_iceoryx_cpp ros2 run demo_nodes_cpp talker
RMW_IMPLEMENTATION=rmw_iceoryx_cpp ros2 run demo_nodes_py listener
RMW_IMPLEMENTATION=rmw_iceoryx_cpp ros2 topic echo /chatter

Screenshot of the iceoryx introspection without fix (pub/sub not connected): cut_off_type_name_introspection

Screenshot of the iceoryx introspection with fix: cut_off_type_name_introspection_fixed

Signed-off-by: Simon Hoinkis simon.hoinkis@apex.ai