search

ros2 / rmw_iceoryx

rmw implementation for iceoryx
Apache License 2.0
144 stars 27 forks source link

Transfer maintenance to Simon #85

Closed Karsten1987 closed 1 year ago

mossmaurice commented 1 year ago

@Karsten1987 Thanks for the PR!

Unfortunately, ament_xmllint doesn't like it:

Error: /home/runner/work/rmw_iceoryx/rmw_iceoryx/rmw_iceoryx_cpp/package.xml:7: element author: Schemas validity error : Element 'author': This element is not expected. Expected is ( maintainer ).

Could you change it to two <maintainer> entries and update it to your current email address? Thanks :pray:

FYI @budrus @ralph-lange As we discussed this morning.

Karsten1987 commented 1 year ago

Is the linter not working correctly then? https://ros.org/reps/rep-0140.html#author-multiple allows an author tag in its definition.

mjcarroll commented 1 year ago

I believe that you need at least one <author> tag. Typically we move the maintainers to authors when passing off.

mossmaurice commented 1 year ago

@Karsten1987 Can you try swapping the lines with <author> and <maintainer>? AFAIU the ordering is defined in the XML schema and <maintainer> has to come first.