search

ros2 / rmw_iceoryx

rmw implementation for iceoryx
Apache License 2.0
144 stars 27 forks source link

Transfer maintenance (rolling) #87

Closed mossmaurice closed 1 year ago

mossmaurice commented 1 year ago

Cherry-picking #85 to master branch.

mossmaurice commented 1 year ago

Upstream Cyclone DDS needs a small change, in order to build with the latest iceoryx master:

 /home/runner/work/rmw_iceoryx/rmw_iceoryx/ros_ws/src/eclipse-cyclonedds/cyclonedds/src/core/ddsi/src/ddsi_shm_transport.c:59:40: error: ‘Iceoryx_LogLevel_Verbose’ undeclared (first use in this function); did you mean ‘Iceoryx_LogLevel_Error’?
     59 |         case DDSI_SHM_VERBOSE : return Iceoryx_LogLevel_Verbose;
        |                                        ^~~~~~~~~~~~~~~~~~~~~~~~
        |                                        Iceoryx_LogLevel_Error

From the changelog:

28. `LogLevel` enum tags are renamed to better match the log4j log levels

    | before     | after   |
    |:----------:|:-------:|
    | `kOff`     | `OFF`   |
    | `kFatal`   | `FATAL` |
    | `kError`   | `ERROR` |
    | `kWarn`    | `WARN`  |
    | `kInfo`    | `INFO`  |
    | `kDebug`   | `DEBUG` |
    | `kVerbose` | `TRACE` |

    In the C binding the `Iceoryx_LogLevel_Verbose` changed to `Iceoryx_LogLevel_Trace`.

cc @MatthiasKillat