ros2 / rmw_implementation

CMake infrastructure and dependencies for rmw implementations
Apache License 2.0
21 stars 47 forks source link

Remove rmw_connext_cpp. #183

Closed clalancette closed 3 years ago

clalancette commented 3 years ago

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

asorbini commented 3 years ago

Actually, one minor addition: you might want to remove the reference to rmw_connext_cpp in test_rmw_implementation/test/config.hpp (I noticed this in my original edits)

clalancette commented 3 years ago

Actually, one minor addition: you might want to remove the reference to rmw_connext_cpp in test_rmw_implementation/test/config.hpp (I noticed this in my original edits)

Good call, fixed in 4687ee4

clalancette commented 3 years ago

CI for this is at https://github.com/ros2/rmw_connextdds/issues/9#issuecomment-805863900 (the yellow jobs are because of an uncrustify error in rclcpp that has since been fixed). So I'm going to go ahead and merge this.