search

ros2 / rmw_implementation

CMake infrastructure and dependencies for rmw implementations
Apache License 2.0
21 stars 48 forks source link

Test SubscriptionOptions::ignore_local_publications #192

Closed jamoralp closed 3 years ago

jamoralp commented 3 years ago

Signed-off-by: Jose Antonio Moral joseantoniomoralparras@gmail.com

Related to https://github.com/ros2/rmw_fastrtps/pull/536

jamoralp commented 3 years ago

LGTM pending green CI

To my understanding, this should happen after a manual trigger, right? Otherwise, there is no way to test it with the changes introduced at https://github.com/ros2/rmw_fastrtps/pull/536

hidmic commented 3 years ago

CI up to test_rmw_implementation:

hidmic commented 3 years ago

Let's try again, CI up to test_rmw_implementation:

hidmic commented 3 years ago

To pass the Rolling PR job (and merge this), we need https://github.com/ros2/rmw_fastrtps/pull/536 released. @MiguelCompany do you want to hold that until https://github.com/ros2/rmw_fastrtps/pull/540 gets in?

hidmic commented 3 years ago

Alright, https://github.com/ros/rosdistro/pull/30076 is up. Once it's in, we can re-run the PR job and merge if everything's still fine.

hidmic commented 3 years ago

@ros-pull-request-builder retest this please

hidmic commented 3 years ago

Alright, all green!