search

ros2 / rmw_implementation

CMake infrastructure and dependencies for rmw implementations
Apache License 2.0
21 stars 48 forks source link

Added tests for bounded sequences serialization #193

Closed MiguelCompany closed 3 years ago

MiguelCompany commented 3 years ago

Regression test for ros2/rmw_fastrtps#540

Depends on ros2/rcl_interfaces#123 Depends on ros2/test_interface_files#14

MiguelCompany commented 3 years ago

Why wouldn't test_msgs/msg/BoundedSequences work?

Because it has strings, which are unbounded

it doesn't seem like test_msgs/msg/UnboundedSequencesNoStrings is used at all

I just added it for symmetry

hidmic commented 3 years ago

CI up to rmw_fastrtps_cpp, rmw_fastrtps_dynamic_cpp, rcl_interfaces and test_rmw_implementation:

hidmic commented 3 years ago

Once again, CI up to rmw_fastrtps_cpp, rmw_fastrtps_dynamic_cpp, rosidl_typesupport_fastrtps, rcl_interfaces, and test_rmw_implementation:

MiguelCompany commented 3 years ago

@hidmic I fixed the linter issues. Would you mind running CI again?

hidmic commented 3 years ago

Third's the charm hopefully:

MiguelCompany commented 3 years ago

@hidmic Last linter issue fixed.

hidmic commented 3 years ago

~Ok, let's start small this time~ Alright, let's go.

hidmic commented 3 years ago

MacOS CI, one more time:

hidmic commented 3 years ago

CI again as it's been a while:

hidmic commented 3 years ago

Almost there. We'll need to release a few packages for the Rpr job to pass here.

hidmic commented 3 years ago

@ros-pull-request-builder retest this please

hidmic commented 3 years ago

@ros-pull-request-builder retest this please

hidmic commented 3 years ago

Alright, finally green. Going in!