search

ros2 / rmw_implementation

CMake infrastructure and dependencies for rmw implementations
Apache License 2.0
21 stars 48 forks source link

Add client/service QoS getters #196

Closed mauropasse closed 2 years ago

mauropasse commented 2 years ago

Blocked by https://github.com/ros2/rmw_fastrtps/pull/560 https://github.com/ros2/rmw_cyclonedds/pull/343 https://github.com/ros2/rmw_connextdds/pull/67

Signed-off-by: Mauro Passerino mpasserino@irobot.com

fujitatomoya commented 2 years ago

test would be nice to add.

mauropasse commented 2 years ago

After some discussion (see https://github.com/ros2/rmw_connextdds/pull/67#discussion_r738447092) I updated all PRs to retrieve independently the QoS for Client request publisher / response subscription and Services request subscription / response publisher.

ivanpauno commented 2 years ago

CI:

PRs being tested: https://github.com/ros2/rmw_fastrtps/pull/560, https://github.com/ros2/rmw_cyclonedds/pull/343, https://github.com/ros2/rmw_connextdds/pull/67, https://github.com/ros2/rmw/pull/314 and this one.

ivanpauno commented 2 years ago

Extra CI run to check linter issues were solved:

All the rmw* PRs look ready to me, I wIll wait for another opinion on the proposed API before merging.

ivanpauno commented 2 years ago

Rpr checker will continue failing until I release rmw, rmw_fastrtps, rmw_connextdds, rmw_cyclonedds. I will merge this PR and then do that.

Blast545 commented 2 years ago

:man_farmer: This PR introduced some linter test regressions into the buildfarm: https://ci.ros2.org/job/nightly_linux_debug/2120/#showFailuresLink.

The linter check job didn't include the package test_rmw_implementation which was modified as well.