search

ros2 / rmw_implementation

CMake infrastructure and dependencies for rmw implementations
Apache License 2.0
21 stars 48 forks source link

Fix renamed `rcpputils` header #198

Closed aprotyas closed 2 years ago

aprotyas commented 2 years ago

rcpputils/get_env.hpp is renamed to rcpputils/env.hpp as part of https://github.com/ros2/rcpputils/pull/150, so the corresponding includes have been fixed in this PR.

Signed-off-by: Abrar Rahman Protyasha aprotyas@u.rochester.edu

aprotyas commented 2 years ago

The Rpr job fails as expected because the renamed header is not in a release yet.

CI from https://github.com/ros2/rcpputils/pull/150:

Repos file: https://gist.github.com/aprotyas/96874af9175859555af0144398e0bf25 Build/Test args: --packages-above-and-dependencies rcpputils ROS distro: Rolling Job: https://ci.ros2.org/job/ci_launcher/9287

CI (again) from https://github.com/ros2/rcpputils/pull/150 following https://github.com/ros2/rcpputils/pull/150/commits/18b406b24f6728d7d2b04d00c332b9898c86205f.

Repos file: https://gist.github.com/aprotyas/96874af9175859555af0144398e0bf25 Build args: --packages-above-and-dependencies rcpputils Test args: --packages-above rcpputils ROS distro: Rolling Job: https://ci.ros2.org/job/ci_launcher/9295

aprotyas commented 2 years ago

Two approvals and CI is green, so I'll merge this in. Thanks for the reviews!