ros2 / rmw_implementation

CMake infrastructure and dependencies for rmw implementations
Apache License 2.0
21 stars 48 forks source link

Don't find_package(ament_index_cpp ..) if RMW is configured at build-time #210

Closed gavanderhoorn closed 1 year ago

gavanderhoorn commented 1 year ago

As per subject.

Should fix #209.

gavanderhoorn commented 1 year ago

I'm currently on Humble, so if this could be backported to humble, that would be :+1:

gavanderhoorn commented 1 year ago

Not sure what to make of the buildfarm build failing.

clalancette commented 1 year ago

Not sure what to make of the buildfarm build failing.

We need to do some Rolling releases. I'll do those in a bit.

clalancette commented 1 year ago

@ros-pull-request-builder retest this please

clalancette commented 1 year ago

@ros-pull-request-builder retest this please

clalancette commented 1 year ago

Well, I don't know why the Rpr job is failing; I can't reproduce that locally. I'm going to run CI on this, and if that is good, merge.

CI:

gavanderhoorn commented 1 year ago

Looks like the Jenkins agents get shut down before the build completes?

clalancette commented 1 year ago

Looks like the Jenkins agents get shut down before the build completes?

Sigh, yes. The aarch64 nodes have been flapping a bit lately. They automatically restart, but the tracking badge doesn't follow that. Updated now.

clalancette commented 1 year ago

CI looks good here (the yellow jobs just have a CMake warning, and that was fixed elsewhere). So going ahead and merging this one.

gavanderhoorn commented 1 year ago

thanks.

Could this one also be backported to Humble?

clalancette commented 1 year ago

@Mergifyio backport humble

mergify[bot] commented 1 year ago

backport humble

✅ Backports have been created

* [#211 Don't find_package(ament_index_cpp ..) if RMW is configured at build-time (backport #210)](https://github.com/ros2/rmw_implementation/pull/211) has been created for branch `humble`