ros2 / rmw_implementation

CMake infrastructure and dependencies for rmw implementations
Apache License 2.0
21 stars 48 forks source link

Expect rmw_service_server_is_available to ret RMW_RET_INVALID_ARGUMENT #231

Closed christophebedard closed 3 months ago

christophebedard commented 3 months ago

https://github.com/ros2/rmw/pull/277 changed the rmw_service_server_is_available() API documentation to indicate that it returns RMW_RET_INVALID_ARGUMENT if node, client, or is_available are NULL. However, this wasn't the case in practice in the implementations of rmw_service_server_is_available() or in the relevant test.

Change the test here to expect RMW_RET_INVALID_ARGUMENT.

Required rmw implementation PRs:

christophebedard commented 3 months ago

CI with this and the 3 rmw PRs:

fujitatomoya commented 3 months ago

@sloretz i do not have permission for cyclone and connexdds, can you merge all 4 PRs together?