ros2 / rmw_implementation

CMake infrastructure and dependencies for rmw implementations
Apache License 2.0
21 stars 48 forks source link

Expect rmw_destroy_wait_set to ret RMW_RET_INVALID_ARGUMENT #234

Closed christophebedard closed 3 months ago

christophebedard commented 3 months ago

https://github.com/ros2/rmw/pull/275 changed the rmw_destroy_wait_set() API documentation to indicate that it returns RMW_RET_INVALID_ARGUMENT if wait_set is NULL. However, this wasn't the case in practice in the implementations of rmw_destroy_wait_set() or in the relevant test.

Change the test here to expect RMW_RET_INVALID_ARGUMENT.

Required rmw implementation PRs:

christophebedard commented 3 months ago

CI with this and the 3 rmw PRs: