ros2 / rmw_implementation

CMake infrastructure and dependencies for rmw implementations
Apache License 2.0
21 stars 48 forks source link

Do not deref msg ptr for rmw_{publish,return}_loaned_message*() #240

Closed christophebedard closed 2 weeks ago

christophebedard commented 2 weeks ago

rmw_return_loaned_message_from_publisher() and rmw_publish_loaned_message() accept a void *, not a void **.

It built fine, but probably failed at runtime. I guess none of the rmws currently exercise this part of the test.

fujitatomoya commented 2 weeks ago

Pulls: ros2/rmw_implementation#240 Gist: https://gist.githubusercontent.com/fujitatomoya/c1b8744a72ea28048cf6c01afceafb49/raw/4af2270abdf521652e83601b1a6bd39c1692da62/ros2.repos BUILD args: --packages-up-to test_rmw_implementation TEST args: --packages-select test_rmw_implementation ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14476

christophebedard commented 2 weeks ago

aaaand I just realized that this is not a deref, it's the opposite :facepalm: