Remove all 'z_encoding(Z_ENCODING_PREFIX_EMPTY, NULL)' as default is EMPTY encoding

ros2 / rmw_zenoh

RMW for ROS 2 using Zenoh as the middleware

Apache License 2.0

144 stars 29 forks source link

Remove all 'z_encoding(Z_ENCODING_PREFIX_EMPTY, NULL)' as default is EMPTY encoding #178

Closed JEnoch closed 1 month ago

JEnoch commented 1 month ago

By default in all options zenoh-c set the encoding to the EMPTY encoding. Thus the calls setting encoding to z_encoding(Z_ENCODING_PREFIX_EMPTY, NULL); are useless and can be removed.

Moreover this fixes #177 which is caused by an issue passing NULL to z_encoding() (https://github.com/eclipse-zenoh/zenoh-c/issues/370).

Yadunund commented 1 month ago

@hwoithe can you confirm if these changes fixes the issue you encounter?

hwoithe commented 1 month ago

This does fix the issue for me. Thank you!