ros2 / rmw_zenoh

RMW for ROS 2 using Zenoh as the middleware
Apache License 2.0
184 stars 34 forks source link

-v option for zenohd #197

Closed JEnoch closed 3 months ago

JEnoch commented 3 months ago

Following discussion in https://github.com/ros2/rmw_zenoh/pull/189 this PR makes zenohd to support a -v command line option to set the logs verbosity level.

Internally, it set the RUST_LOG environment variable a value that depends on the number of -v options in the command line. If RUST_LOG is already defined when starting the command, the -v options are ignored. This allows user to finely tune the logging if he wants.

JEnoch commented 3 months ago

What do you think is missing in the current documentation of RUST_LOG ?

clalancette commented 3 months ago

What do you think is missing in the current documentation of RUST_LOG ?

The only thing I was thinking was to add the =trace portion from this PR.

But we discussed it in the meeting today, and we decided to close this for now. If you think it is useful to add that to the README, please feel free to open another PR.