[Feature] Introduce include-what-you-use into the build pipeline

ros2 / rmw_zenoh

RMW for ROS 2 using Zenoh as the middleware

Apache License 2.0

218 stars 36 forks source link

[Feature] Introduce include-what-you-use into the build pipeline #323

Open YuanYuYuan opened 5 days ago

YuanYuYuan commented 5 days ago

          I see. I'm unaware of this pattern. We usually trust the compiler in Rust. But when I studied this pattern and tried to apply the tool [include-what-you-use](https://github.com/include-what-you-use/include-what-you-use), I got many warnings. What do you think about introducing the check of include-what-you-use?

iwyu.txt

_Originally posted by @YuanYuYuan in https://github.com/ros2/rmw_zenoh/pull/276#discussion_r1849899825_

YuanYuYuan commented 5 days ago

Furthermore, I think we need to wrap the ROS dependencies with brackets rather than quotes as include-what-you-use suggsted. And this way is also recommended in the ROS community. https://answers.ros.org/question/348742/double-quotes-vs-angled-brackets-for-rosrosh/