Example with simple_bridge doesn't work

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2

Apache License 2.0

452 stars 288 forks source link

Example with simple_bridge doesn't work #262

Closed sshmaxime closed 4 years ago

sshmaxime commented 4 years ago

Bug report

Required Info:

Operating System:
- OSX but building and running in Docker
Installation type:
- binaries
Version or commit hash:
- 5f70a38cf4ad9f11767350052552c260dd5301e9
DDS implementation:
- default
Client library (if applicable):
- rclcpp

Steps to reproduce issue

Follow the tutorial in the README.md and use simple_bridge instead of dynamic_bridge

Expected behavior

Data correctly transmitted from ROS1 talker node to ROS2 listener node.

Actual behavior

Nothing is being received by the listener.

Additional information

Can do the PR if necessary. The fix is to change the the QoS policies and replace rclcpp::SensorDataQoS() by 10 as it's the one being used everywhere.

jacobperron commented 4 years ago

@MaximeAubanel Sounds like you are building from source on top of a binary installation. Can you clarify which version of ROS 2 you have installed (e.g. Dashing or Eloquent)?

sshmaxime commented 4 years ago

What do you mean by "building from source on top of a binary installation" ?

I'm using Eloquent.

jacobperron commented 4 years ago

Sorry, I was just confused by:

OSX but building and running in Docker

dirk-thomas commented 4 years ago

@MaximeAubanel Please provide reproducible steps.

sshmaxime commented 4 years ago

As I said in my first comment, you just need to follow the tutorial.

Basically, you need to have to follow your README.md. When reaching the first example https://github.com/ros2/ros1_bridge#example-1a-ros-1-talker-and-ros-2-listener, instead of running ros2 run ros1_bridge dynamic_bridge run ros2 run ros1_bridge simple_bridge. Is that enough ?

dirk-thomas commented 4 years ago

Since the fix was trivial I created #264 to resolve this.