search

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2
Apache License 2.0
452 stars 288 forks source link

When generating service mappings cast pair to set to avoid duplicate pairs #268

Closed suddrey-qut closed 4 years ago

suddrey-qut commented 4 years ago

Fixes issue #257

Recreation of PR #259 to do master->master

dirk-thomas commented 4 years ago

Thanks for the patch.

peterpena commented 4 years ago

Should this be backported?

dirk-thomas commented 4 years ago

Should this be backported?

@peterpena Into which ROS distro?

peterpena commented 4 years ago

@dirk-thomas I am not sure what ROS distro it will be. The bug seems to be introduced all the way back to Ardent. What is the protocol to decide the ROS distro?

dirk-thomas commented 4 years ago

What is the protocol to decide the ROS distro?

Only active distro can be patched (so the earliest would be Dashing). Another criteria is if it is necessary / severe enough. Based on the original issue it seems trivial to avoid this case by not defining a custom mapping which replicates the default behavior. So I would think the need to backport is fairly low.

peterpena commented 4 years ago

I see. Thanks for the explanation. I felt the need to ask if it needed to be backported, but based on what you said, it seems that it might not be necessary.