Allow exclusion of / ignoring of msg types

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2

Apache License 2.0

452 stars 288 forks source link

Allow exclusion of / ignoring of msg types #284

Open norro opened 4 years ago

norro commented 4 years ago

Allow to exclude certain message types and/or packages from the rosbridge build. This could be done at cmake time, e.g., through cmake configuration options.

AFAIR, this can be helpful to:

ignore message types that are not compatible between ROS 1 und ROS 2 or don't have a proper, therefore breaking the rosbridge build
reduce rosbridge build time

norro commented 4 years ago

I think both a blacklist as well as a whitelist of types might be reasonable. What do you think?

clalancette commented 4 years ago

Hi @norro ,

This sounds like a good enhancement to the bridge. Could you create a pull request implementing this feature? Thanks.

norro commented 4 years ago

Sure, I will give it a shot.

norro commented 3 years ago

I think a package blacklist/whitelist is more suited for the use-case of reducing build time, whereas a message blacklist/whitelist is more suited for the use-case of ignoring message types that are not compatible between ROS 1 und ROS 2.