Fix for mapping rule with same type and different name

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2

Apache License 2.0

452 stars 288 forks source link

Closed iuhilnehc-ynos closed 3 years ago

iuhilnehc-ynos commented 3 years ago

Signed-off-by: Chen Lihui lihui.chen@sony.com

(Updated, not to relate the 285 issue for Linked pull requests)

tgaspar commented 3 years ago

I have implemented your changes on my end and it does work as intended.

Removing the or ros1_name != ros2_name check seems to be a reasonable thing to do there.

Thanks for taking the time to do this.

iuhilnehc-ynos commented 3 years ago

@sloretz, Could you review it when you become free?

iuhilnehc-ynos commented 3 years ago

There is a friendly person @ipa-hsd to resolve the issue https://github.com/ros2/ros1_bridge/issues/285, close this PR. I'll keep an eye on that and test it.