[forward port] update to use rosidl_parser and .idl files rather than rosidl_adapter and .msg files

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2

Apache License 2.0

452 stars 288 forks source link

[forward port] update to use rosidl_parser and .idl files rather than rosidl_adapter and .msg files #296

Closed wjwwood closed 3 years ago

wjwwood commented 3 years ago

This is forward porting a change from Dashing made in https://github.com/ros2/ros1_bridge/pull/292 into master.

CI:

ci_packaging_linux:

Once this one is merged, I'll backport it to Foxy and Eloquent.

closes https://github.com/ros2/ros1_bridge/issues/187

wjwwood commented 3 years ago

CI after fixing linting issue:

wjwwood commented 3 years ago

For backports, do you think we should address backwards compatibility concerns raised here #292 (comment) ?

It seems like we're ok leaving Dashing as-is there, so I assume the same is true for backports to other branches (e.g. foxy, eloquent), does that sound right? @jacobperron @sloretz

Either way I think this is the right way for this to be done on master.

jacobperron commented 3 years ago

@wjwwood Friendly ping for a Foxy backport. I'm not sure if the ship has sailed for an Eloquent backport.

wjwwood commented 3 years ago

Yeah, I was waiting for the fix in https://github.com/ros2/ros1_bridge/pull/298.