search

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2
Apache License 2.0
436 stars 283 forks source link

very minor typo in comments #297

Closed Vicidel closed 3 years ago

Vicidel commented 3 years ago

as the documentation for parameter bridge is lacking, better to have comments without typo to avoid time waste on the user side

nuclearsandwich commented 3 years ago

@Vicidel these changes are probably small enough not to need a DCO but if you add one it will make the bot happy and we don't have to think about it.

Vicidel commented 3 years ago

The DCO guide there doesn't work for me with error :

$ git push --force-with-lease origin patch-1
ERROR: Permission to ros2/ros1_bridge.git denied to Vicidel.
fatal: Could not read from remote repository.

I'll try to solve this for the future.

nuclearsandwich commented 3 years ago

The DCO guide there doesn't work for me with error :

I expect it is failing because I've applied the suggestions as a further commit on top of your changes. If you do a git pull --rebase origin patch-1 before trying again I think that should do it.

sloretz commented 3 years ago

@Vicidel friendly ping :) Thanks for the PR! Mind trying the fix @nuclearsandwich suggested?

Vicidel commented 3 years ago

Sorry for the delay, I tested it but I still have errors:

$ git pull --rebase origin patch-1
fatal: Couldn't find remote ref patch-1
$ git push --force-with-lease origin patch-1
remote: Permission to ros2/ros1_bridge.git denied to Vicidel.
fatal: unable to access 'https://github.com/ros2/ros1_bridge.git/': The requested URL returned error: 403
Vicidel commented 3 years ago

Sorry about this, I'm not used to open source and these kind of things. I will be careful in the future to comply to DCO. Thank you for the merge