Fix logging for updated rclcpp interface

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2

Apache License 2.0

436 stars 283 forks source link

Fix logging for updated rclcpp interface #303

Closed mjcarroll closed 3 years ago

mjcarroll commented 3 years ago

This has caused failures in the nightly jobs on platforms where ros1_bridge is built.

I believe that it is related to this PR: https://github.com/ros2/rclcpp/pull/1442

@audrow Can you confirm that this was an expected side effect?

audrow commented 3 years ago

Also, this is an expected side effect. After ros2/rclcpp#1442, the logging macros only accept char *s and the format argument should be a string literal.

mjcarroll commented 3 years ago

Linux
Linux-aarch64
macOS
Windows

mjcarroll commented 3 years ago

This actually requires the ci_packaging job, since it's ros1_bridge: