search

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2
Apache License 2.0
452 stars 288 forks source link

Add hardcoded QoS for the /tf_static topic for parameter bridge #304

Closed lFatality closed 2 years ago

lFatality commented 3 years ago

Hello everyone,

the hardcoded QoS (keep all, transient local) for the /tf_static topic that were introduced to the dynamic bridge are quite useful and I think they should be added to the parameter bridge as well. This pull request introduces an API to create bidirectional bridges with adjustable QoS for the 1->2 publisher. This API is then used in the parameter bridge to change the QoS for the /tf_static topic.

Cheers lFatality

P.S.: This is my very first pull request to an open source project so let me know if I miss some steps or something like that :)

LoyVanBeek commented 2 years ago

From the description, I think the just merged https://github.com/ros2/ros1_bridge/pull/331 also does what you want.

lFatality commented 2 years ago

@LoyVanBeek Yes you're right, that solves the same problem. So I'll close this pull request.