search

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2
Apache License 2.0
436 stars 283 forks source link

Use rcpputils/scope_exit.hpp instead of rclcpp/scope_exit.hpp #324

Closed christophebedard closed 3 years ago

christophebedard commented 3 years ago

See https://github.com/ros2/rclcpp/pull/1727#issuecomment-901241040

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

christophebedard commented 3 years ago

I'm guessing GitHub CI is enough? Since ros1_bridge is seemingly always ignored by ci.ros2.org

clalancette commented 3 years ago

I'm guessing GitHub CI is enough? Since ros1_bridge is seemingly always ignored by ci.ros2.org

You should be able to run the ci_packaging job, which builds the bridge.

christophebedard commented 3 years ago

You should be able to run the ci_packaging job, which builds the bridge.

ah I see!