search

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2
Apache License 2.0
452 stars 288 forks source link

Allow .msg/.srv files to be in subdirectories of msg/, srv/ #325

Open janstrohbeck opened 3 years ago

janstrohbeck commented 3 years ago

If one has the following ROS1 message layout:

msg/
  group1/
    MessageDefinition1.msg
    MessageDefinition2.msg
  group2/
    MessageDefinition3.msg

That is, the .msg files are not directly in the msg folder, but in subfolders. Then the bridge does not find the message files correctly. The same goes for files in subfolders in the srv directory. This PR expands the search for .msg and .srv files to subdirectories, to make it work.

gbiggs commented 2 years ago

@janstrohbeck You wouldn't happen to have a test of a minimal reproducible example I can use to verify this works, would you?