search

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2
Apache License 2.0
425 stars 275 forks source link

Fix cpplint error #341

Closed Blast545 closed 2 years ago

Blast545 commented 2 years ago

This should fix the linter errors on the rolling jobs: https://ci.ros2.org/view/packaging/job/packaging_linux/2525/ https://ci.ros2.org/view/packaging/job/packaging_linux-aarch64/1877/ https://build.ros2.org/view/Rci/job/Rci__nightly-release_ubuntu_focal_amd64/569/

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

Blast545 commented 2 years ago

@clalancette I wanted to trigger a ci_linux job using the same parameters as the packaging_linux but the ci_linux one doesn't have the parameter CI_MIXED_ROS_OVERLAY_PKGS (where actually ros1_bridge is added).

What can I do to test this PR in this scenario?

clalancette commented 2 years ago

What can I do to test this PR in this scenario?

You can trigger https://ci.ros2.org/job/ci_packaging_linux/ and https://ci.ros2.org/job/ci_packaging_linux-aarch64/

Blast545 commented 2 years ago

@clalancette Oh, I didn't know about that one. Thanks!

ci_packaging_linux up to rcutils with cycloneDDS only (the error does not come from the ros2 environment, so it's not needed to build the whole thing) Build Status

ci_packaging_linux up to ros1_bridge with cycloneDDS only Build Status

Blast545 commented 2 years ago

I tested 3538f0f with cpplint locally, it should pass the CI test.

ci_packaging_linux up to ros1_bridge with cycloneDDS only Build Status

Blast545 commented 2 years ago

@ros-pull-request-builder retest this please