Bug fix for fields in service calls with different names.

tompe17 commented 2 years ago

This is my fix for the issue in #285

fujitatomoya commented 2 years ago

@tompe17 could you address DCO error https://github.com/ros2/ros1_bridge/pull/347/checks?check_run_id=5623872538 ?

gbiggs commented 2 years ago

CI:

Linux

tompe17 commented 2 years ago

Do I need to do anything more with this or will this be merged? It would very good if this functionality could work in the next release of ROS2 since we will depend on it until DJI releases it ROS SDK for ROS2 if that ever will happen.

gbiggs commented 2 years ago

@tompe17 You have been asked a question by @fujitatomoya. I'm waiting for your reply before merging this.

tompe17 commented 2 years ago

Concerning unrelated changed since I have not the faintest idea about why that is I could not answer it. I can only describe what I did:

I forked the repo
I made a branch and did the changes
I made the pull request
There was the issue with a signature so I followed the instructions to fix that. Some day after that I for a messaged that the email address was invalid since it by mistake started with @.
So i tried to fix that and repeted the original fix that was suggested after fixing my buggy email address I had in a config file.
I tried that a couple of times since it did not seem to help. The I saw that @gbiggs hade approves something so I thought everything was OK.

I am not familiar enough with github and pull requests to understand if what I did have caused some problems or not.

gbiggs commented 2 years ago

@fujitatomoya Could you be specific about which changes you think are unrelated?

methylDragon commented 2 years ago

@gbiggs

My suspicion is these:

Suggestion: Rebase the branch on master, which should remove a lot of the extra commits, it'll also fix the conflicts since the creation of this PR.

gbiggs commented 2 years ago

@tompe17 Can you please rebase your PR?

ros2 / ros1_bridge

Bug fix for fields in service calls with different names. #347