Print out message mapping for fields_2_to_1 rule

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2

Apache License 2.0

425 stars 275 forks source link

Print out message mapping for fields_2_to_1 rule #365

Closed quarkytale closed 2 years ago

quarkytale commented 2 years ago

As reported in #353, mapping rules from ros2 fields to ros1 fields aren't being printed out. Apparently, the mapping dictionary structure wasn't being populated nor the fields_2_to_1 tag was being checked in the string pairs data.

gbiggs commented 2 years ago

Do you think this can be unit tested?

quarkytale commented 2 years ago

Do you think this can be unit tested?

I'm not well versed with unit tests, but we'll need to pass the custom messages and mapping rules to validate. Adding GTest would suitable I guess?

quarkytale commented 2 years ago

CI_Packaging_Linux

quarkytale commented 2 years ago

Thanks a lot, Chris! CI_Packaging_Linux: