ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2
Apache License 2.0
425 stars 275 forks source link

Fixed index for ros2 namespace type messages #366

Closed quarkytale closed 2 years ago

quarkytale commented 2 years ago

As reported in #354 bridge fails when ros2 message uses standard namespaces (std_msgs, geometry_msgs, etc.) to be mapped with ros1 messages. Note: this works as expected when no namespaces are used on ros2 side, regardless of what's on ros1 side.

It was failing while returning package name and message name parsed from a rosidl_parser.definition.NamespacedType object. Type field was incorrect, seems to be using rosidl_parser for messages and rosidl_adapter for services, as far as my understanding. Updated the function description too.

quarkytale commented 2 years ago

CI_Linux_Packaging Build Status