Closed methylDragon closed 2 years ago
Looks like this package needs a fix (unrelated to this PR): https://github.com/ros2/ci/pull/669
The test build is running assuming that the CI PR is merged in, it shouldn't block this PR.
Looks good but I couldn't run it successfully, using this setup let me know if I'm missing something!
Humm, let me see
I'll need to add a custom ament resource... Sec
OMG it's green!!! Merging
Nice! Thanks, again! Was following along the PR discussion and planning to test it today but ended up getting sidetracked on something else. Will try backporting to eloquent locally and test it next week.
Nice! Thanks, again! Was following along the PR discussion and planning to test it today but ended up getting sidetracked on something else. Will try backporting to eloquent locally and test it next week.
Be sure to check out the docs for how to set this up!
Backported locally to eloquent and can confirm that it works as expected.
Excellent!
As requested by, and closes: https://github.com/ros2/ros1_bridge/issues/364
Description
This PR implements a new
enable_foreign_mappings
mapping rule that allows one to override the package name check that forces a user to define any mapping rules that target a bridge ROS 2 package from that package itself.This will let you define mappings from OUTSIDE a target message's package.
Reminder
As in the
Known Issues
section, you'll probably need to run the bridge with--bridge-all-topics
to get the bridge working with custom messages.Example Usage
See the docs for more details
Set the
enable_foreign_mappings
rule totrue
/True
/1 in your custom mapping rules file! It'll override the check for EVERY RULE defined in that file!And also add an ament resource (
ros1_bridge_foreign_mapping
) in the mapping package, which will allow the mapping package to be found! In theCMakeLists.txt
of your mapping package (which is NOT the msgs package!!), before the mapping rules install call:The implementation is tested locally, and seems to work (with messages).