ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2
Apache License 2.0
425 stars 275 forks source link

[question] YAML with mapping rules - which package should have it? #370

Closed ljaniec closed 2 years ago

ljaniec commented 2 years ago

Hello,

I am trying to bridge my custom ROS1 and ROS2 message packages, unfortunately, without much success.

My question:

Which version is correct? I think the documentation should be more precise there.

quarkytale commented 2 years ago

Hi the message mapping rule YAML file should reside in the ROS2 msgs package, included in ROS2 msgs package CMakeLists.txt and package.xml.

quarkytale commented 2 years ago

See this as an example, it was created for another issue but should help with file structure and installation. Note: ros1_bridge is a submodule in that repository, either git submodule update or manually clone it, if you're trying it out!

ljaniec commented 2 years ago

Thank you for the answer. I hope some additional notes will be added to the documentation so it will be clear for everyone

quarkytale commented 2 years ago

Sure, it'll be added with this commit https://github.com/ros2/ros1_bridge/pull/367/commits/7c6dcb91bfca85476353ab4f0fdbb9083d727155 in another PR.