Move xmlrpcpp find_package so it only searches if ROS 1 is found

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2

Apache License 2.0

425 stars 275 forks source link

Move xmlrpcpp find_package so it only searches if ROS 1 is found #371

Closed gbiggs closed 2 years ago

gbiggs commented 2 years ago

This PR makes the xmlrpcpp dependency search only occur if ROS 1 is found. This is because on a system with only ROS 2 installed, xmlrpcpp might not be installed, leading to the build of ros1_bridge failing for an unexpected (by the user) reason.

For more info, see this comment: https://github.com/ros2/ros1_bridge/pull/331#issuecomment-1188111510

gbiggs commented 2 years ago

CI:

gbiggs commented 2 years ago

Trying again, with actually including ros1_bridge this time.

gbiggs commented 2 years ago

Third time lucky!